Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set isRoboTest to true for robo tests #2535

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

SelaseKay
Copy link
Collaborator

@SelaseKay SelaseKay commented Oct 23, 2024

Description

This PR fixes the issue where isRoboTest was initially set to false by default, and was not being updated for Robo test matrices. The fix adds isRoboTest = newMatrix.isRoboTest to the updateProperties function, ensuring that the isRoboTest field is correctly set when the matrix properties are updated.

Related issues

fixes #2497

.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@kaibolay kaibolay merged commit 7a9163b into Flank:master Oct 28, 2024
4 of 5 checks passed
@SelaseKay SelaseKay deleted the fix_wrong_robo_test_value branch November 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isRoboTest never set in matrix_ids.json for Robo Test matrices
3 participants